Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually re-trigger introspection #2618

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

This PR add a function that contains the logic for running introspection to the schema context from @graphiql/react. It also adds a toolbar button and a short key that can be used to trigger this.

(After the refactoring that we did this turned out to be super simple, so I figured we can as well to another minor to push this out in 1.x.)

CleanShot.2022-08-01.at.15.23.06.mp4

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

🦋 Changeset detected

Latest commit: c6e050d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphiql Minor
@graphiql/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #2618 (c6e050d) into main (2d91916) will increase coverage by 3.80%.
The diff coverage is 23.84%.

@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
+ Coverage   65.70%   69.51%   +3.80%     
==========================================
  Files          85       71      -14     
  Lines        5106     4202     -904     
  Branches     1631     1408     -223     
==========================================
- Hits         3355     2921     -434     
+ Misses       1747     1276     -471     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 47.61% <66.66%> (+0.63%) ⬆️
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b8875...c6e050d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@thomasheyenbrock thomasheyenbrock force-pushed the feat/manually-trigger-introspection branch from 2ff3f21 to c6e050d Compare August 1, 2022 13:53
@thomasheyenbrock
Copy link
Collaborator Author

I also rebased the graphiql-v2 branch on top of this one (locally for now) and ported this feature like so:

CleanShot.2022-08-01.at.15.58.11.mp4

@thomasheyenbrock thomasheyenbrock merged commit 4c81450 into main Aug 4, 2022
@thomasheyenbrock thomasheyenbrock deleted the feat/manually-trigger-introspection branch August 4, 2022 16:10
@acao acao mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant