Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't invoke callback on empty changes #2565

Merged
merged 1 commit into from
Jul 13, 2022
Merged

don't invoke callback on empty changes #2565

merged 1 commit into from
Jul 13, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

Fixes #2548

This prevents us from firing change handlers on "empty" changes, in particular when calling codeMirror.signal(editorInstance, "change", editorInstance) (we do this when updating metadata stored on the editor objects like variable types, document AST, etc)

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

🦋 Changeset detected

Latest commit: 5f26b2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphiql/react Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #2565 (5f26b2f) into main (2d91916) will increase coverage by 3.75%.
The diff coverage is 24.16%.

@@            Coverage Diff             @@
##             main    #2565      +/-   ##
==========================================
+ Coverage   65.70%   69.46%   +3.75%     
==========================================
  Files          85       71      -14     
  Lines        5106     4156     -950     
  Branches     1631     1376     -255     
==========================================
- Hits         3355     2887     -468     
+ Misses       1747     1264     -483     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9903042...5f26b2f. Read the comment docs.

@thomasheyenbrock thomasheyenbrock merged commit f581b43 into main Jul 13, 2022
@thomasheyenbrock thomasheyenbrock deleted the issues/2548 branch July 13, 2022 12:23
@acao acao mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating query calls both onEditQuery and onEditVariables handlers
1 participant