-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error display for websocket fetchers #2535
Conversation
🦋 Changeset detectedLatest commit: 37fa61e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared
|
Codecov Report
@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
+ Coverage 65.70% 69.52% +3.82%
==========================================
Files 85 71 -14
Lines 5106 4204 -902
Branches 1631 1410 -221
==========================================
- Hits 3355 2923 -432
+ Misses 1747 1276 -471
- Partials 4 5 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yeah i think this is a longtime issue, maybe not a regression, so feel free to fix it in 2.0.0. will take a look at this later today! |
We could also fix that with a new patch in v1 as we decided not to do the prereleases and this does not contain breaking changes 😉 |
ah yes of course! i was hoping to make it easier on you but that's exactly what we agreed to isn't it, i forgot we have a path for this now! so nice to have, looking forward to using pre-release more often it looks like there is a new cypress failure here, are you familar with this one? https://github.com/graphql/graphiql/runs/7176376103?check_suite_focus=true#step:8:412 |
oh my bad i see the write tests task |
ee64674
to
5fe8147
Compare
Fixes #2534
The issue is caused by the default ws-fetcher which wraps joins multiple error messages and wraps them in a new error.
Open TODOs: