Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing caller arguments #2526

Merged
merged 1 commit into from
Jun 30, 2022
Merged

add missing caller arguments #2526

merged 1 commit into from
Jun 30, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

For users of @graphiql/react we want to make clear which hook or component is missing which context provider. We achieve this by forwarding the function that was called by the user via caller attributes to the editor consumers that require a certain context to be present.

We are already doing this for lots of places, just in some this was missing (which is my oversight 😅 ), so this is just a tiny usability fix.

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2022

🦋 Changeset detected

Latest commit: f892f36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphiql/react Patch
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #2526 (f892f36) into main (2d91916) will increase coverage by 2.64%.
The diff coverage is 23.64%.

@@            Coverage Diff             @@
##             main    #2526      +/-   ##
==========================================
+ Coverage   65.70%   68.35%   +2.64%     
==========================================
  Files          85       71      -14     
  Lines        5106     4181     -925     
  Branches     1631     1387     -244     
==========================================
- Hits         3355     2858     -497     
+ Misses       1747     1318     -429     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718755d...f892f36. Read the comment docs.

@github-actions
Copy link
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@thomasheyenbrock thomasheyenbrock merged commit 26e4412 into main Jun 30, 2022
@thomasheyenbrock thomasheyenbrock deleted the fix/caller-arguments branch June 30, 2022 15:47
@acao acao mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant