move tabs state to editor context in @graphiql/react
#2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57ab4b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thomasheyenbrock
force-pushed
the
feat/tabs-context
branch
from
5e844c3 to
17a2338
Compare
Codecov Report
@@ Coverage Diff @@
## main #2452 +/- ##
==========================================
+ Coverage 65.70% 67.77% +2.06%
==========================================
Files 85 71 -14
Lines 5106 4369 -737
Branches 1631 1460 -171
==========================================
- Hits 3355 2961 -394
+ Misses 1747 1403 -344
- Partials 4 5 +1
Continue to review full report at Codecov.
|
timsuchanek
approved these changes
May 30, 2022
thomasheyenbrock
force-pushed
the
issues/2442
branch
from
64fb294 to
b4aa4d8
Compare
thomasheyenbrock
force-pushed
the
feat/tabs-context
branch
from
17a2338 to
57ab4b8
Compare
|
The latest changes of this PR are not available as canary, since there are no linked |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves over the state management for tabs into the
EditorContextprovided by@graphiql/react. We always manage the tab state, even when tabs are not shown in the UI. That way we don't have to conditionally render a separate context and keep it in sync with the editor context.