Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move state for doc explorer visibility to explorer context in @graphiql/react #2436

Merged
merged 3 commits into from
May 27, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

@thomasheyenbrock thomasheyenbrock commented May 25, 2022

In addition we can now also move the logic for clicking references to get to the docs into @graphiql/react, that way we don't need to pass the onClickReference and onHintInformationRender props to the editors anymore.

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

🦋 Changeset detected

Latest commit: 90dbf49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphiql Patch
@graphiql/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #2436 (90dbf49) into main (2d91916) will increase coverage by 3.39%.
The diff coverage is 68.43%.

@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
+ Coverage   65.70%   69.10%   +3.39%     
==========================================
  Files          85       71      -14     
  Lines        5106     4421     -685     
  Branches     1631     1470     -161     
==========================================
- Hits         3355     3055     -300     
+ Misses       1747     1361     -386     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-toolkit/src/storage/query.ts 36.73% <ø> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89f0244...90dbf49. Read the comment docs.

@thomasheyenbrock thomasheyenbrock force-pushed the feat/docs-explorer-visibility branch from 17a6b62 to cb1a42a Compare May 25, 2022 10:23
Copy link
Member

@timsuchanek timsuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feat/operation-facts to main May 27, 2022 11:00
@thomasheyenbrock thomasheyenbrock force-pushed the feat/docs-explorer-visibility branch from cb1a42a to 90dbf49 Compare May 27, 2022 11:02
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@thomasheyenbrock thomasheyenbrock merged commit 3e5295f into main May 27, 2022
@thomasheyenbrock thomasheyenbrock deleted the feat/docs-explorer-visibility branch May 27, 2022 11:08
@acao acao mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants