-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move state for doc explorer visibility to explorer context in @graphiql/react
#2436
Conversation
🦋 Changeset detectedLatest commit: 90dbf49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #2436 +/- ##
==========================================
+ Coverage 65.70% 69.10% +3.39%
==========================================
Files 85 71 -14
Lines 5106 4421 -685
Branches 1631 1470 -161
==========================================
- Hits 3355 3055 -300
+ Misses 1747 1361 -386
- Partials 4 5 +1
Continue to review full report at Codecov.
|
17a6b62
to
cb1a42a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cb1a42a
to
90dbf49
Compare
The latest changes of this PR are not available as canary, since there are no linked |
In addition we can now also move the logic for clicking references to get to the docs into
@graphiql/react
, that way we don't need to pass theonClickReference
andonHintInformationRender
props to the editors anymore.