Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move GraphQL utils from graphiql to @graphiql/toolkit #2419

Merged
merged 5 commits into from
May 23, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

We move over:

  • fillLeafs
  • getSelectedOperationName
  • mergeAst

Also the getQueryFacts utility module was unused (just re-exporting stuff from graphql-language-service), so we remove it.

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2022

🦋 Changeset detected

Latest commit: e4d01cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
graphiql Patch
@graphiql/toolkit Minor
@graphiql/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #2419 (e4d01cb) into main (2d91916) will increase coverage by 3.31%.
The diff coverage is 71.67%.

@@            Coverage Diff             @@
##             main    #2419      +/-   ##
==========================================
+ Coverage   65.70%   69.02%   +3.31%     
==========================================
  Files          85       72      -13     
  Lines        5106     4587     -519     
  Branches     1631     1517     -114     
==========================================
- Hits         3355     3166     -189     
+ Misses       1747     1417     -330     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-toolkit/src/storage/query.ts 36.73% <ø> (ø)
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be164b...e4d01cb. Read the comment docs.

@thomasheyenbrock thomasheyenbrock force-pushed the feat/storage-and-history-context branch from 090f48c to e5551ba Compare May 21, 2022 11:50
@thomasheyenbrock thomasheyenbrock force-pushed the refactor/utils-to-toolkit branch from e817f50 to 903dbb7 Compare May 21, 2022 11:51
Copy link
Member

@timsuchanek timsuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasheyenbrock thomasheyenbrock force-pushed the feat/storage-and-history-context branch from e5551ba to 8000ace Compare May 23, 2022 12:43
Base automatically changed from feat/storage-and-history-context to main May 23, 2022 13:53
@thomasheyenbrock thomasheyenbrock force-pushed the refactor/utils-to-toolkit branch from 903dbb7 to 52afc40 Compare May 23, 2022 13:55
@github-actions
Copy link
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@thomasheyenbrock thomasheyenbrock merged commit 84d8985 into main May 23, 2022
@thomasheyenbrock thomasheyenbrock deleted the refactor/utils-to-toolkit branch May 23, 2022 14:47
@acao acao mentioned this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants