move storage classes to toolkit #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 91faabd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #2412 +/- ##
==========================================
+ Coverage 65.70% 68.16% +2.45%
==========================================
Files 85 75 -10
Lines 5106 4702 -404
Branches 1631 1547 -84
==========================================
- Hits 3355 3205 -150
+ Misses 1747 1493 -254
Partials 4 4
Continue to review full report at Codecov.
|
thomasheyenbrock
force-pushed
the
feat/result-editor-to-context
branch
from
33b32ee to
81cd37a
Compare
thomasheyenbrock
force-pushed
the
refactor/storage-to-toolkit
branch
from
966dee3 to
a3881c9
Compare
thomasheyenbrock
force-pushed
the
refactor/storage-to-toolkit
branch
from
a3881c9 to
91faabd
Compare
|
The latest changes of this PR are not available as canary, since there are no linked |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StorageAPIand the things that build on top of it (QueryStoreandHistoryStore) are quite generic and reusable. This PR moves all three of them over into the toolkit package. I sneaked in minor code improvements but overall there didn't change anything about how these classes function.