-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving graphql-ws
to a dynamic import and display a nice message when not found
#2407
Conversation
🦋 Changeset detectedLatest commit: c248619 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report
@@ Coverage Diff @@
## main #2407 +/- ##
==========================================
- Coverage 65.70% 65.10% -0.61%
==========================================
Files 85 81 -4
Lines 5106 5261 +155
Branches 1631 1701 +70
==========================================
+ Hits 3355 3425 +70
- Misses 1747 1832 +85
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for jumping on this ❤️ Just a tiny comment around the error message
Updated 👍 @thomasheyenbrock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjdlambert seems like the new test is not passing yet 👀 can you have another look please?
…t installed. Moved to a dynamic import instead. Signed-off-by: blam <[email protected]>
Derp. Should be good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks again! 👏
why did github tag this as |
Fixes #2405