Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving graphql-ws to a dynamic import and display a nice message when not found #2407

Merged
merged 1 commit into from
May 17, 2022

Conversation

benjdlambert
Copy link
Contributor

Fixes #2405

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Latest commit: c248619

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphiql/toolkit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: benjdlambert / name: Ben Lambert (6237d92)

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #2407 (c248619) into main (2d91916) will decrease coverage by 0.60%.
The diff coverage is 69.77%.

@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   65.70%   65.10%   -0.61%     
==========================================
  Files          85       81       -4     
  Lines        5106     5261     +155     
  Branches     1631     1701      +70     
==========================================
+ Hits         3355     3425      +70     
- Misses       1747     1832      +85     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
...aphiql/src/components/DocExplorer/DefaultValue.tsx 50.00% <ø> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f695b1...c248619. Read the comment docs.

Copy link
Collaborator

@thomasheyenbrock thomasheyenbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for jumping on this ❤️ Just a tiny comment around the error message

packages/graphiql-toolkit/src/create-fetcher/lib.ts Outdated Show resolved Hide resolved
@benjdlambert
Copy link
Contributor Author

Updated 👍 @thomasheyenbrock

Copy link
Collaborator

@thomasheyenbrock thomasheyenbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjdlambert seems like the new test is not passing yet 👀 can you have another look please?

…t installed. Moved to a dynamic import instead.

Signed-off-by: blam <[email protected]>
@benjdlambert
Copy link
Contributor Author

Derp. Should be good now!

Copy link
Collaborator

@thomasheyenbrock thomasheyenbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks again! 👏

@thomasheyenbrock thomasheyenbrock merged commit bc3dc64 into graphql:main May 17, 2022
@acao acao mentioned this pull request May 17, 2022
@acao
Copy link
Member

acao commented May 31, 2022

why did github tag this as @graphiql/react??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve graphql-ws from @graphiql/toolkit/esm/create-fetcher
3 participants