LSP Server should parse more JS extensions #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2442543 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest changes of this PR are available as canary in npm (based on the declared |
Codecov Report
@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
- Coverage 65.70% 63.34% -2.37%
==========================================
Files 85 94 +9
Lines 5106 5442 +336
Branches 1631 1715 +84
==========================================
+ Hits 3355 3447 +92
- Misses 1747 1990 +243
- Partials 4 5 +1
Continue to review full report at Codecov.
|
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
There are a bunch more extensions people are using these days for javascript so it's time to honor them. This *should* fix #1955 when published to `vscode-graphql`, though graphql shouldn't be trying to parse those files anyways, so a bit more digging is in order
acao
force-pushed
the
handle-more-js-extensions
branch
from
dc6db4c
to
0eef383
Compare
github-actions
bot
temporarily deployed
to
graphiql-webpack-preview
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
acao
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many more extensions people are using these days for javascript so it's time to honor all of them. This should fix #1955 when published to
vscode-graphql, though graphql shouldn't be trying to parse those files anyways, so a bit more digging is in order