Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support older targets so there are less webpack bugs #1838

Merged
merged 3 commits into from
Apr 24, 2021

Conversation

acao
Copy link
Member

@acao acao commented Apr 18, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2021

🦋 Changeset detected

Latest commit: 0c55456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
graphql-language-service Patch
monaco-graphql Patch
codemirror-graphql Patch
graphiql Patch
@graphiql/toolkit Patch
graphql-language-service-interface Patch
graphql-language-service-parser Patch
graphql-language-service-types Patch
graphql-language-service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao acao force-pushed the chore/older-targets branch from cb88fcc to f56719b Compare April 18, 2021 23:47
@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

Merging #1838 (0c55456) into main (2d91916) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   65.70%   65.91%   +0.20%     
==========================================
  Files          85       85              
  Lines        5106     5108       +2     
  Branches     1631     1622       -9     
==========================================
+ Hits         3355     3367      +12     
+ Misses       1747     1737      -10     
  Partials        4        4              
Impacted Files Coverage Δ
packages/graphiql/src/components/GraphiQL.tsx 58.09% <100.00%> (+0.58%) ⬆️
...hql-language-service-server/src/findGraphQLTags.ts 64.89% <100.00%> (+4.25%) ⬆️
packages/graphiql/src/components/ToolbarButton.tsx 92.85% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65aa648...0c55456. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2021

@acao acao force-pushed the chore/older-targets branch 2 times, most recently from 1efb4df to e188a46 Compare April 19, 2021 15:49
@acao acao force-pushed the chore/older-targets branch from e188a46 to f1bc10e Compare April 19, 2021 15:53
@acao acao merged commit 5b8a057 into main Apr 24, 2021
@acao acao deleted the chore/older-targets branch April 24, 2021 12:39
This was referenced Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant