Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graphiql] - Upgrading to 3.1.0 causes runtime error #3509

Open
1 task done
oferitz opened this issue Jan 21, 2024 · 3 comments
Open
1 task done

[graphiql] - Upgrading to 3.1.0 causes runtime error #3509

oferitz opened this issue Jan 21, 2024 · 3 comments

Comments

@oferitz
Copy link

oferitz commented Jan 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

#2763 - Already mention this issue, maybe a regression?

Current Behavior

After upgrading graphiql from 3.0.5 to 3.1.0 i'm getting the following runtime error in the browser console

Screenshot 2024-01-21 at 14 01 54

Expected Behavior

Upgrading error should not throw error

Steps To Reproduce

No response

Environment

  • GraphiQL Version: 3.1.0
  • OS: macOS 14.1.2
  • Browser: Chrome 120
  • Bundler: Vite
  • react Version: 18.2.0
  • graphql Version: 16.8.1

Anything else?

No response

@mutefiRe
Copy link

mutefiRe commented Feb 6, 2024

Happens for us as well when using toolbar with additionalContent with a plugin which uses useEditorContext.

E.g. with using the plugin from this pull request: #3055

I think if that is expected to happen then I feel like some documentation for the toolbar and adding a how-to do a toolbar plugin is missing.

@vibdev
Copy link

vibdev commented Jul 25, 2024

If you add a no-op for the caller you can get a new error:

useEditorContext({
    nonNull: true,
    caller: () => {},
  });
Screenshot 2024-07-25 at 3 27 33 PM

@oferitz
Copy link
Author

oferitz commented Oct 13, 2024

#3509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants