fix monaco-graphql bug with _cacheSchemas() (#2105)

Introduced this slight bug with major impact to `monaco-graphql` last night whilst moving things around. Make sure `_cacheSchemas()` is always called on init in the `LanguageService`
graphql · Dec 8, 2021 · f7dc1f1 · f7dc1f1 · github-actions · Dec 8, 2021
1 parent 7d634f8
commit f7dc1f1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/fuzzy-ants-float.md b/.changeset/fuzzy-ants-float.md
@@ -0,0 +1,5 @@
+---
+'monaco-graphql': patch
+---
+
+Fix a bug where `_cacheSchemas()` was not being called by the language service
diff --git a/packages/monaco-graphql/src/LanguageService.ts b/packages/monaco-graphql/src/LanguageService.ts
@@ -64,10 +64,10 @@ export class LanguageService {
     this._schemaLoader = defaultSchemaLoader;
     if (schemas) {
       this._schemas = schemas;
+      this._cacheSchemas();
     }
     if (parser) {
       this._parser = parser;
-      this._cacheSchemas();
     }
 
     if (parseOptions) {