rebase and enable merged rules

graphql · Dec 8, 2022 · c517e47 · c517e47
1 parent fc418a1
commit c517e47
Show file tree

Hide file tree

Showing 4 changed files with 308 additions and 2,686 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -261,12 +261,17 @@ module.exports = {
     ],
     // Jest rules
     'jest/no-conditional-expect': 0,
+
+    'promise/no-multiple-resolved': 'error',
+    'sonarjs/no-redundant-jump': 'error',
+    'unicorn/prefer-logical-operator-over-ternary': 'error',
+    'unicorn/throw-new-error': 'error',
   },
 
-  plugins: ['@typescript-eslint'],
+  plugins: ['@typescript-eslint', 'promise', 'sonarjs', 'unicorn'],
 
   overrides: [
-    // Cypress plugin, global, etc. only for cypress directory
+    // Cypress plugin, global, etc., only for cypress directory
     // https://github.com/cypress-io/eslint-plugin-cypress
     // cypress clashes with jest expect()
     {

diff --git a/examples/monaco-graphql-react-vite/src/App.tsx b/examples/monaco-graphql-react-vite/src/App.tsx
@@ -188,8 +188,6 @@ export default function App() {
           });
 
           setSchema(data.data);
-
-          return;
         })
         .then(() => setLoading(false));
     }

diff --git a/package.json b/package.json
@@ -118,8 +118,11 @@
     "eslint-plugin-cypress": "^2.12.1",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-jest": "^27.1.6",
+    "eslint-plugin-promise": "^6.1.1",
     "eslint-plugin-react": "^7.31.11",
     "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-sonarjs": "^0.17.0",
+    "eslint-plugin-unicorn": "^45.0.1",
     "execa": "^6.0.0",
     "express": "^4.17.3",
     "fetch-mock": "6.5.2",