turn valid-typeof as error (#2274)

Co-authored-by: Rikki Schulte <[email protected]>
graphql · Apr 7, 2022 · 1295038 · 1295038
1 parent 1122ce2
commit 1295038
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/blue-baboons-begin.md b/.changeset/blue-baboons-begin.md
@@ -0,0 +1,6 @@
+---
+"@graphiql/toolkit": patch
+"graphiql": patch
+---
+
+turn `valid-typeof` as `error`, SSR fix
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -79,7 +79,7 @@ module.exports = {
     'no-unsafe-negation': 1,
     'use-isnan': 1,
     'valid-jsdoc': 0,
-    'valid-typeof': 1,
+    'valid-typeof': 'error',
 
     // Best Practices (http://eslint.org/docs/rules/#best-practices)
     'accessor-pairs': 1,

diff --git a/packages/graphiql-toolkit/src/create-fetcher/createFetcher.ts b/packages/graphiql-toolkit/src/create-fetcher/createFetcher.ts
@@ -17,7 +17,7 @@ import {
  */
 export function createGraphiQLFetcher(options: CreateFetcherOptions): Fetcher {
   let httpFetch;
-  if (typeof window !== null && window?.fetch) {
+  if (typeof window !== 'undefined' && window.fetch) {
     httpFetch = window.fetch;
   }
   if (