Resolve all options during construction #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
leebyron
force-pushed
the
dont-hold-options
branch
from
21c5668
to
6504744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than holding a reference to the provided options and computing behaviors and defaults on the fly, this validates and extracts all options during construction.
Minor additional behavioral changes include allowing
cacheMapto be set tonullas an equivalence tocache: falseand providing the DataLoader instance asthistocacheKeyFnto be consistent with doing the same forbatchLoadFn.Finally, this adds additional tests and makes minor edits to documentation.