Fix Rocket integration #67
Conversation
Rocket's traits have changed in version 0.3.0, this commit adjusts the existing implementation to be compatible with the latest version of the traits.
|
@stankec great, thanks for the PR. The build is failing on Windows on nightly due to Should be good to merge. |
|
@stankec also could you add information about the upgrade to If you don't get around to it, I'll bolt it on later. |
|
@theduke AppVeyor may be failing due to rust-lang/rust#42422 And I couldn't find the unreleased section in the Sorry for the inconvenience, It's just not clear to me what to do. |
|
I just added it yesterday after your PR. ;) |
|
@theduke I did update the example. And I run the test suite, everything passed. I'm even running the example on my machine. (Started with Are you referring to the need for a better example? |
|
Haha well you shouldn't look at code after 3 hours of sleep. @stankec Sorry bout that. |
|
FYI, I have just tried to build It's seems that Ring is definitely the problem |
|
The tests are failing on Travis too, we're just ignoring failures on nightly: https://travis-ci.org/mhallin/juniper/jobs/258473732 It seems as if Rocket has removed or renamed their As for the Ring build failure, it seems as if they're not compatible with the GCC toolchain: https://github.com/briansmith/ring and that's why it's failing. We could probably get by with disabling the Rocket integration for Windows+GCC builds. |
|
Pardons. I’ll be busy tomorrow until the evening. I can do it on monday for
sure.
Does that suite you?
…On 29 July 2017 at 20:46:19, theduke ***@***.***) wrote:
@stankec <https://github.com/stankec> as recorded in #70
<#70>, we'd like to pull out
rocket and iron integrations into juniper_rocket and juniper_iron crates.
Would handling the extraction for iron be something you are up to?
If not, I'll do it tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABlBsh11ONWodlFcurKaLPxDnTqETq9Mks5sS337gaJpZM4OmWHW>
.
|
|
The tests are failing on nightly because this change is incomplete and the rocket integration tests fail. See the We need to replace this: https://github.com/mhallin/juniper/pull/67/files#diff-576d7531dece2e01a8a09d86ff09c869L155 Also, 👍 on creating new crates Edit: I had missed mhallin's comment mentioning this. My bad. |
|
Hey. This completely slipped my mind. My laptop literally caught fire on Monday morning. I'll get to it in the evening. |
Updated changelog with preliminary info about project restructure and custom derives.
This split still requires some work as the tests currently fail. This is caused by the fact that some previously private modules can't be accessed anymore, and that Rocket changet it's testing framework.
|
@stankec cheers! I already started with moving the iron integration too. Since this has a lot of overlap, I will include your commits in my branch and then do a combined merge request if that is fine with you. This actually involves a lot of stuff... fixing the documentation, moving the tests, fixing the |
|
That’s fine with me :)
…On 3 August 2017 at 14:32:16, theduke ***@***.***) wrote:
@stankec <https://github.com/stankec> cheers!
I already started with moving the iron integration too.
Since this has a lot of overlap, I will include your commits in my branch
and then do a combined merge request if that is fine with you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#67 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABlBsopoZhdKfIzieOE0YicxI2bvPgOtks5sUb3QgaJpZM4OmWHW>
.
|
|
Merged as part of #73 |
Rocket's traits have changed in version 0.3.0, this pull request adjusts the existing implementation to be compatible with the latest version of the traits.