Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci #462

Merged
merged 2 commits into from
Jan 9, 2024
Merged

update ci #462

merged 2 commits into from
Jan 9, 2024

Conversation

danieleades
Copy link
Contributor

No description provided.

Copy link

@TieWay59 TieWay59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donno much about dtolnay/rust-toolchain can you tell us some reason?

@tomhoule
Copy link
Member

tomhoule commented Jan 9, 2024

actions-rs/toolchain is not maintained and depends on node, while dtolnay/rust-toolchain is bash and maintained, so I support the move.

@TieWay59
Copy link

TieWay59 commented Jan 9, 2024

I understand dtolnay/rust-toolchain now.

BTW replacing .get(0) is not related to your ci change right? Maybe you need to address it in the PR body or split it in another PR?

Edit: I understand it's definitely correct & trivial for running the code. But it's a little inconvenient for review when you said A but also done B. People would be confused about whether it's intended.

@danieleades
Copy link
Contributor Author

I understand dtolnay/rust-toolchain now.

BTW replacing .get(0) is not related to your ci change right? Maybe you need to address it in the PR body or split it in another PR?

Edit: I understand it's definitely correct & trivial for running the code. But it's a little inconvenient for review when you said A but also done B. People would be confused about whether it's intended.

The change is intentional, because without it the CI jobs for this PR will fail

@tomhoule
Copy link
Member

tomhoule commented Jan 9, 2024

Let's try this.

@tomhoule tomhoule merged commit a7283cb into graphql-rust:main Jan 9, 2024
@danieleades danieleades deleted the CI branch January 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants