Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support middlewares for subscriptions #221

Merged

Conversation

nrbnlulu
Copy link
Contributor

@nrbnlulu nrbnlulu commented Jul 2, 2024

Fix #188

I am not sure if this requires more tests because AFAIR its basically the same as async execution.
Please let me know it needs more @Cito

@nrbnlulu
Copy link
Contributor Author

nrbnlulu commented Jul 5, 2024

@Cito can you aprove the workflows?

@Cito
Copy link
Member

Cito commented Jul 5, 2024

Thanks, will review this tomorrow.

Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

Just minor stylistic changes for consistency, see suggestions.

tests/execution/test_middleware.py Outdated Show resolved Hide resolved
tests/execution/test_middleware.py Show resolved Hide resolved
tests/execution/test_middleware.py Outdated Show resolved Hide resolved
tests/execution/test_middleware.py Outdated Show resolved Hide resolved
tests/execution/test_middleware.py Outdated Show resolved Hide resolved
tests/execution/test_middleware.py Outdated Show resolved Hide resolved
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dummy resolver can be removed.

tests/execution/test_middleware.py Outdated Show resolved Hide resolved
@Cito Cito merged commit 876aef6 into graphql-python:main Jul 7, 2024
9 checks passed
@nrbnlulu nrbnlulu deleted the support-middlewares-for-subscriptions branch July 8, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can subscriptions have middleware?
2 participants