-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support middlewares for subscriptions #221
Support middlewares for subscriptions #221
Conversation
@Cito can you aprove the workflows? |
Thanks, will review this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you.
Just minor stylistic changes for consistency, see suggestions.
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dummy resolver can be removed.
Co-authored-by: Christoph Zwerschke <[email protected]>
Fix #188
I am not sure if this requires more tests because AFAIR its basically the same as async execution.
Please let me know it needs more @Cito