Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable recursive type definitions #218

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Enable recursive type definitions #218

merged 2 commits into from
Apr 9, 2024

Conversation

yilinjuang
Copy link
Contributor

Mypy supports recursive types now.

python/mypy#731
python/mypy#14219

@yilinjuang yilinjuang requested a review from Cito as a code owner April 9, 2024 09:36
Cito
Cito approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for contributing.

There are still some minor issues, see failing QA test and comments.

src/graphql/pyutils/path.py Outdated Show resolved Hide resolved
src/graphql/validation/rules/overlapping_fields_can_be_merged.py Show resolved Hide resolved
@Cito Cito merged commit ddfe2bf into graphql-python:main Apr 9, 2024
9 checks passed
@yilinjuang yilinjuang deleted the patch-mypy branch April 9, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Cito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yilinjuang @Cito