refactor: WIP introspection from schema using typeddict #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cito
force-pushed
the
main
branch
3 times, most recently
from
4f69c9b to
1804bd7
Compare
Cito
force-pushed
the
main
branch
3 times, most recently
from
0ac79de to
3f40fc2
Compare
|
Thank you for the contribution, finally came back to this and implemented it in 24506f3 using TypedDicts, since we are using dicts as introspection results. Unfortunately, the implementation of TypedDicts in mypy has some weaknesses (no recursion, no generics) so this is not as good as it could be. Closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress based on #99 request.
cc @Cito