Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.1: build depends on setuptools and poetry. Is that correct?🤔 #178

Closed
kloczek opened this issue Aug 7, 2022 · 4 comments
Closed
Milestone

Comments

@kloczek
Copy link

kloczek commented Aug 7, 2022

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting dependencies for wheel...

Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/pep517/wrappers.py", line 332, in _call_hook
    raise BackendUnavailable(data.get('traceback', ''))
pep517.wrappers.BackendUnavailable: Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/pep517/in_process/_in_process.py", line 89, in _build_backend
    obj = import_module(mod_path)
  File "/usr/lib64/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 961, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'poetry'

However after adding poetry-core to build env ..

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting dependencies for wheel...

ERROR Missing dependencies:
        setuptools>=59,<70

hmm 🤔

@kloczek
Copy link
Author

kloczek commented Sep 7, 2022

Just tested that commit and with it still pep157 build requires both setuptools and poetry-core

+ /usr/bin/python3 -sBm build -w --no-isolation
* Getting dependencies for wheel...

ERROR Missing dependencies:
        setuptools>=59,<70

@Cito Cito reopened this Sep 12, 2022
@Cito
Copy link
Member

Cito commented Sep 12, 2022

@kloczek Yes, #180 does not solve this issue.

GraphQL-py has both a setup.py and a pyproject.toml to support both ways of installation.

Will clean this up eventually and do whatever is currently best practice. If you have any links or recommendations let me know.

@kloczek kloczek changed the title 3.2.1: build depends on setuptools and 'poetry`. Is that correct?🤔 3.2.1: build depends on setuptools and poetry. Is that correct?🤔 Sep 12, 2022
@Cito Cito added this to the v3.3 milestone Sep 22, 2022
Cito added a commit that referenced this issue Sep 23, 2022
That means we also don't need MANIFEST.in and check-manifest any more.
@Cito
Copy link
Member

Cito commented Sep 23, 2022

This is now fixed in the main branch (used for the upcoming 3.3 release), we only require poetry as build tool now.

@Cito
Copy link
Member

Cito commented Oct 23, 2022

Fix available in v3.3.0a1 for testing.

@Cito Cito closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants