Add description to schema parser and printer #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indent function wasn't actually indenting. Add the indent to the function and fix up the one call site.
phil303
force-pushed
the
add-description-2
branch
2 times, most recently
from
0af0dbc to
845fefb
Compare
phil303
force-pushed
the
add-description-2
branch
3 times, most recently
from
3f62fa8 to
93574c3
Compare
Descriptions are now part of the [graphql spec](https://facebook.github.io/graphql/June2018/#sec-Descriptions). This commit brings graphql-core inline with the spec.
phil303
force-pushed
the
add-description-2
branch
from
93574c3 to
3338aaa
Compare
|
@jkimbo @syrusakbary Hey guys, what can I do to move this PR forward? |
|
This feature would be really useful as other GraphQL libraries in other languages support descriptions. |
|
Another vote for getting this merged (cc @jkimbo and @syrusakbary). Thanks for this, @phil303! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions are now part of the graphql spec. This commit brings graphql-core inline with the spec.
There's an additional commit in here that fixes the
indentfunction in the printer. It's not a requirement for handling descriptions.One note, the business logic in here is heavily lifted from the JS reference implementation.