Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nullvalue #119

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yen223
Copy link

@yen223 yen223 commented May 11, 2017

Resolves #118

@syrusakbary
Copy link
Member

I will happily merge this if we can add more tests like in the ref implementation!
https://github.com/graphql/graphql-js/pull/544/files :)

@waxisien
Copy link

waxisien commented Oct 3, 2017

@yen223 Do you plan to continu this PR? That's a very useful feature.

jaemk added a commit to jaemk/graphql-core that referenced this pull request May 4, 2018
- addresses graphql-python#118
- initial implementation by @yen223 in PR graphql-python#119
jaemk added a commit to jaemk/graphql-core that referenced this pull request May 4, 2018
- addresses graphql-python#118
- initial implementation by @yen223 in PR graphql-python#119
@jaemk jaemk mentioned this pull request May 4, 2018
@syrusakbary syrusakbary force-pushed the master branch 3 times, most recently from b1f26c1 to a7ce75e Compare July 19, 2018 18:24
@mrshankly
Copy link

What's the status of this pull request? This would be very helpful for us.

@rok-povsic
Copy link

This feature would be very useful. Right now, I have to create another mutation that's used only for setting argument object fields to null.

jaemk added a commit to jaemk/graphql-core that referenced this pull request Sep 17, 2018
- addresses graphql-python#118
- initial implementation by @yen223 in PR graphql-python#119
jaemk added a commit to jaemk/graphql-core that referenced this pull request Sep 18, 2018
- addresses graphql-python#118
- initial implementation by @yen223 in PR graphql-python#119
jaemk added a commit to jaemk/graphql-core that referenced this pull request Sep 18, 2018
- addresses graphql-python#118
- initial implementation by @yen223 in PR graphql-python#119
@altaurog
Copy link

altaurog commented Nov 7, 2018

I will happily merge this if we can add more tests like in the ref implementation!
https://github.com/graphql/graphql-js/pull/544/files :)

@syrusakbary which, specifically, of the tests there would you like implemented? It seems to me that project has a broader set of tests overall than this one and the tests @yen223 added are consistent with the scope of the existing tests.

@samlll42-github
Copy link

Any update on this? thanks

@ArnaudPel
Copy link

ArnaudPel commented Apr 10, 2019

Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary

@kkitay
Copy link

kkitay commented Apr 19, 2019

likewise, would very much like this to be possible

@hugos94
Copy link

hugos94 commented May 10, 2019

Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary

@brabeji
Copy link

brabeji commented Aug 5, 2019

Joining the crowd of onlookers waiting for updates on this PR. Thanks @syrusakbary

Maybe the https://github.com/graphql-python/graphql-core/issues/249 release might resolve this issue, @jkimbo?

@jkimbo
Copy link
Member

jkimbo commented Aug 18, 2019

@brabeji yes the graphql-core v3 (#249) will resolve this issue. Graphql-core v3 is going to be graphql-core-next which is a complete rewrite bringing it up to feature parity with graphql.js

cpmsmith pushed a commit to fellowapp/graphql-core-legacy that referenced this pull request Apr 27, 2022
- addresses graphql-python#118
- initial implementation by @yen223 in PR graphql-python#119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement null literal