Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Related issue #154 )
Hi, I just spend my sunday porting this package to graphene v3 and graphql-relay-py v3. I never used this package (nor mongo), so I didn't have the chance to test my changes with an real project.
There is one problem we need to think about: dataloaders and the promise library
There is a dataloader test which I only got green by resolving the dataloaders promise myself. I guess before graphene resolved it, but as far as I can tell graphene dropped support for promise dataloaders.
One more thing to consider is that graphene now requires Python >=3.6. (CI also tests 2.7, 3.4 and 3.5, thus CI fails).
Additional infomation can be found in the graphene v3 release notes and the graphene v3 issue: graphql-python/graphene#1127