Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to close the aiohttp session if connector_owner is False #382

Merged

Conversation

leszekhanusz
Copy link
Collaborator

See issue #381

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (132d4dc) compared to base (f28670d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        27    +2     
  Lines         2321      2358   +37     
=========================================
+ Hits          2321      2358   +37     
Impacted Files Coverage Δ
gql/transport/aiohttp.py 100.00% <100.00%> (ø)
gql/utils.py 100.00% <0.00%> (ø)
gql/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@shawnlewis shawnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leszekhanusz leszekhanusz merged commit 2981ce3 into graphql-python:master Jan 30, 2023
@leszekhanusz leszekhanusz deleted the feature_connector_owner_false branch January 30, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants