-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support subgraph datasources #1754
Conversation
🦋 Changeset detectedLatest commit: b75cda9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying graph-tooling with Cloudflare Pages
|
Hey @incrypto32, thanks for the PR ! Gonna take a bit of time to review. In the meantime if you can provide some more context/information as to what these feature would bring to developers, would be very much appreciated thanks 👍 |
Given the context, we'll also wait for some of the related PRs in |
Hey @0237h , i'll write up the required context soon. TL;DR is this will support the code generation and the new type of datasource thats being added as part of the subgraph composition feature. As you mentioned. Yes those graph-node PR's need to be merge before getting this out. I'll write a detailed comment on the changes later. |
@0237h I just added a description to the PR. let me know if more info is needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@incrypto32 Thanks for the updated description !
A few minor comments, other LGTM.
Do you know if the graph-node
integration for subgraph datasources is also ready ?
Doesn't seem to work for me. After running |
Oops, i think i didn't check the |
@YaroShkvorets just added the init command. Please re review |
|
Let's merge it @0237h , then let @incrypto32 polish out any bugs. |
@YaroShkvorets as will this be released soon? |
Yes, let's coordinate on the release. |
This PR adds new types for subgraph datasources to graph-ts and codegen functionality to generate schema code for the source subgraphs.
Detailed docs about subgraph datasources here.
This PR
EntityTrigger
type tograph-ts
which is the Assemblyscript represenation of entity triggers.EntityOp
which represents the entity operations done on the source subgraph