Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add remove method codegen for mutable entities #1555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yura2100
Copy link

@yura2100 yura2100 commented Dec 30, 2023

This PR introduces remove method generation for mutable entities only. remove method is a wrapper around store.remove. The implementation is similar to save method.

export class Account extends Entity {
  ...
  remove(): void {
    let id = this.get('id');
    assert(id != null, 'Cannot remove Account entity without an ID');
    if (id) {
      assert(
        id.kind == ValueKind.STRING,
        `Entities of type Account must have an ID of type String but the id '${id.displayData()}' is of type ${id.displayKind()}`,
      );
      store.remove('Account', id.toString());
    }
  }
  ...
}

Copy link

changeset-bot bot commented Dec 30, 2023

⚠️ No Changeset found

Latest commit: 7402f51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yura2100 yura2100 changed the title Add remove method codegen for mutable entities feat: Add remove method codegen for mutable entities Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant