graph: Fix an error in KillState::new #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems worth a comment |
|
True - I made the mistake of putting the comment into the commit message. Fixed now. |
|
@lutter I think you forgot to push the change. |
lutter
force-pushed
the
lutter/lm-init
branch
2 times, most recently
from
8b5bfc4
to
7b049ba
Compare
I did indeed; rebased to latest master and pushed for realz |
leoyvens
approved these changes
Jul 24, 2020
On Mac OSX, Instant::now() is the time since the last boot, which might have been less than a day ago, in which case KillState::new would panic. We now use 'now - 60s' as a time in the past for initialization, and if that fails, we'll use just 'now'. There's not much danger in using 'now', it might just lead to spurious logging and a too-soon update of the kill_rate if the node becomes immediately overloaded after starting. Thanks to kevholder for root-causing the issue and demonstrating a fix. Fixes #1805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac OSX, Instant::now() is the time since the last boot, which might
have been less than a day ago, in which case KillState::new would panic. We
now use 'now - 60s' as a time in the past for initialization, and if that
fails, we'll use just 'now'. There's not much danger in using 'now', it
might just lead to spurious logging and a too-soon update of the kill_rate
if the node becomes immediately overloaded after starting.
Thanks to kevholder for root-causing the issue and demonstrating a fix.
Fixes #1805