fix: update function visibility (OZ N-16) #1051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Title:
N-16 Function Visibility Overly Permissive
Details:
Throughout the codebase, multiple instances of functions with unnecessarily permissive visibility were identified:
The _verifyAllocationProof function in AllocationManager.sol with internal visibility could be limited to private.
The _getDelegatedTokensAvailable function in HorizonStakingBase.sol with internal visibility could be limited to private.
The _receiveIndexerStake and _receiveDelegation functions in HorizonStakingExtension with internal visibility could be made private.
The _deposit function in PaymentsEscrow.sol with internal visibility could be limited to private.
The acceptDispute and drawDispute functions in DisputeManager.sol with public visibility could be limited to external.
To better convey the intended use of functions, consider changing a function's visibility to be only as permissive as required.
Key changes