fix: standardize naming conventions throughout the codebase (OZ N-13)

[MoonBoi9001]

Motivation:

• This PR addresses the following N-13 OZ audit issue, applying some of the recommended fixes.

Title:

N-13 Naming Suggestions

Details:

Throughout the codebase, multiple instances where code would benefit from renaming were identified:

• function releaseStake(uint256 n) could be function releaseStake(uint256 numClaimsToRelease).
• function _setPartialPaused(bool _toPause) could be function _setPartialPaused(bool _toPartialPause).
• lastPausePartialTime could be lastPartialPauseTime.
• acceptProvision could be acceptProvisionPendingParameters. Additionally, staged could be pending.
• Multiple variables follow the convention of _DEPRECATED{variable_name}, whereas they will only be deprecated after the transition period. Consider renaming them to _DEPRECATING{variable_name} and switching to the current naming after they are truly deprecated.
• IHorizonStakingMain could be IHorizonStaking to ease reading and match the implementing contract.
• maxVerifierCut and thawingPeriod could be newMaxVerifierCut and newThawingPeriod.
• sharesThawing and tokensThawing could be sharesStillThawing and tokensStillThawing.
• onlyProvisionAuthorized could be onlyAuthorizedForProvision.
• ProvisionAccepted could be ProvisionPendingParametersAccepted.
• releaseAt could be releasableAt.
• _tokens could be amount.
• Resolve the conflicting dispute could be Draw the conflicting dispute.
• In order to avoid confusion, consider limiting the use of thawing and unthawing to only instances referring to provisions. We suggest renaming MAX_THAWING_PERIOD to MAX_WAIT_PERIOD and taking a likewise approach when dealing with all the similar occurrences in the PaymentsEscrow contract.
• In the DisputeManager contract, the terms "challenger" and "submitter" are used interchangeably with "fisherman", leading to potential confusion. Consider consistently using the term "fisherman".
  Consider reviewing the aforementioned suggestions and applying them to improve code clarity and readability.

Review suggestion

• It might make more sense to look at the induvidual commits instead of the files changed.

Key changes

• releaseStake n parameter changed to numClaimsToRelease.
• function _setPartialPaused(bool _toPause) chnaged to function _setPartialPaused(bool _toPartialPause).
• lastPausePartialTime now lastPartialPauseTime
• acceptProvision updated to acceptProvisionPendingParameters.
• rename staged to pending.
• rename maxVerifierCut to newMaxVerifierCut and thawingPeriod to newThawingPeriod.
• onlyProvisionAuthorized now onlyAuthorizedForProvision.
• ProvisionAccepted now ProvisionPendingParametersAccepted.
• releaseAt updated to releasableAt.
• "Resolve the conflicting dispute" updated to "Draw the conflicting dispute" in the dispute manager contract.
• Update MAX_THAWING_PERIOD to MAX_WAIT_PERIOD in payments escrow contract.
• Terms "challenger" and "submitter" updated to "fisherman".

Ignored suggestions

• Multiple variables follow the convention of _DEPRECATED{variable_name}, whereas they will only be deprecated after the transition period. Consider renaming them to _DEPRECATING{variable_name} and switching to the current naming after they are truly deprecated.
• IHorizonStakingMain could be IHorizonStaking to ease reading and match the implementing contract.
• sharesThawing and tokensThawing could be sharesStillThawing and tokensStillThawing.
• _tokens could be amount.

[openzeppelin-code]

fix: standardize naming conventions throughout the codebase (OZ N-13)

Generated at commit: e33bf12ae2fdbbac69700dc8dc08a04a5ac3f649

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 4 0 15 40 61
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (374f57d) to head (e33bf12).
Report is 60 commits behind head on horizon.

Additional details and impacted files

@@           Coverage Diff            @@
##           horizon    #1047   +/-   ##
========================================
  Coverage    92.51%   92.51%           
========================================
  Files           46       46           
  Lines         2392     2392           
  Branches       428      428           
========================================
  Hits          2213     2213           
  Misses         179      179           

Flag	Coverage Δ
unittests	92.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tmigone]

Looks good, one comment:

This contract we dont need to change packages/contracts/contracts/disputes/DisputeManager.sol. That's the old (current) Dispute Manager which we won't be touching/deploying, instead we have a new one in packages/subgraph-service/... which you already updated.

[MoonBoi9001]

Have reverted changes to that contract now :)

[tmigone]

🚢