Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add active Indexers query #31

Merged
merged 1 commit into from
Feb 15, 2024
Merged

feat: add active Indexers query #31

merged 1 commit into from
Feb 15, 2024
+561 −243

Conversation

pete-eiger
Copy link
Contributor

@pete-eiger pete-eiger commented Feb 12, 2024 •
edited
Loading

  • MAX_STORAGE changed to be optional
  • Added new RETENTION config var
  • Added new GraphQL API query - query_active_indexers
  • Added new db resolver - list_active_indexers

@pete-eiger pete-eiger requested a review from hopeyen February 12, 2024 15:04
@pete-eiger pete-eiger self-assigned this Feb 12, 2024
@pete-eiger pete-eiger linked an issue Feb 12, 2024 that may be closed by this pull request
[Feat.Req] Add query for fetching active Indexers #28
Closed
hopeyen
hopeyen reviewed Feb 12, 2024
View reviewed changes
src/db/resolver.rs Outdated

static MIGRATOR: Migrator = sqlx::migrate!();

async fn setup_test_db() -> PgPool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain why is this fn used instead of sqlx::test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@pete-eiger pete-eiger force-pushed the petko/active-indexers-query branch from bfe3d8f to a8811c6 Compare February 13, 2024 06:31
@pete-eiger pete-eiger requested a review from hopeyen February 13, 2024 06:31
hopeyen
hopeyen previously approved these changes Feb 13, 2024
View reviewed changes
@pete-eiger pete-eiger force-pushed the petko/active-indexers-query branch from 9b2fde1 to cd55787 Compare February 14, 2024 15:32
@pete-eiger pete-eiger requested a review from hopeyen February 14, 2024 15:32
@pete-eiger pete-eiger force-pushed the petko/active-indexers-query branch from cd55787 to 6b49249 Compare February 14, 2024 15:33
hopeyen
hopeyen previously approved these changes Feb 14, 2024
View reviewed changes
@pete-eiger pete-eiger force-pushed the petko/active-indexers-query branch from cafb77b to b879b91 Compare February 15, 2024 12:50
@pete-eiger pete-eiger requested a review from hopeyen February 15, 2024 13:57
hopeyen
hopeyen previously approved these changes Feb 15, 2024
View reviewed changes
@pete-eiger pete-eiger requested a review from hopeyen February 15, 2024 17:35
@pete-eiger pete-eiger force-pushed the petko/active-indexers-query branch 2 times, most recently from e93d809 to 369a023 Compare February 15, 2024 17:39
hopeyen
hopeyen previously approved these changes Feb 15, 2024
View reviewed changes
@pete-eiger pete-eiger force-pushed the petko/active-indexers-query branch from 369a023 to 3f9e083 Compare February 15, 2024 18:44
@pete-eiger pete-eiger requested a review from hopeyen February 15, 2024 18:48
@pete-eiger pete-eiger merged commit 0668702 into dev Feb 15, 2024
4 checks passed
@pete-eiger pete-eiger deleted the petko/active-indexers-query branch February 15, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen approved these changes

Assignees

@pete-eiger pete-eiger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat.Req] Add query for fetching active Indexers
2 participants
@pete-eiger @hopeyen