Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace charged language "whitelist/blacklist" #1700

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

obfuscurity
Copy link
Member

This PR replaces #1570, fixing a merge conflict.

Addressing #1569

Related to graphite-project/carbon#567 / graphite-project/carbon#568

@codecov-io
Copy link

codecov-io commented Sep 15, 2016

Current coverage is 65.61% (diff: 95.23%)

Merging #1700 into master will not change coverage

@@             master      #1700   diff @@
==========================================
  Files            54         54          
  Lines          6122       6122          
  Methods           0          0          
  Messages          0          0          
  Branches       1210       1210          
==========================================
  Hits           4017       4017          
  Misses         1892       1892          
  Partials        213        213          

Powered by Codecov. Last update 20d443b...a32b395

@obfuscurity
Copy link
Member Author

I'm pushing this back to the next milestone for now. I would like to see this go in but after working on it for a day I feel like there's room for improvement in terms of naming clarity. I've gone through it a few times and caught myself getting confused with some of the functions/settings.

@obfuscurity obfuscurity modified the milestones: 1.1.0, 1.0.0 Sep 16, 2016
@obfuscurity
Copy link
Member Author

refs graphite-project/carbon#591

@stale
Copy link

stale bot commented Apr 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants