Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/orgs #120

Merged
merged 5 commits into from
Apr 1, 2023
Merged

Dev/orgs #120

merged 5 commits into from
Apr 1, 2023

Conversation

lmeyerov
Copy link
Contributor

@lmeyerov lmeyerov commented Mar 31, 2023

Added

  • all: Optional orgs login

Docs

  • all: Arrow uploads and login modes

Published as v4.6.0-alpha.2

@lmeyerov lmeyerov requested a review from aucahuasi March 31, 2023 07:38
@@ -26,6 +26,7 @@ export class Client extends ClientBase {
* @constructor
* @param {string} username - Graphistry server username
* @param {string} password - Graphistry server password
* @param {string} org - Graphistry organization (optional)
Copy link

@aucahuasi aucahuasi Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use brackets [] too to indicate that org is optional with the default value undefined:
* @param {string} [org=undefined] - Graphistry organization (optional)

Copy link

@aucahuasi aucahuasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants