When queuing multiple jobs at once, nudge more than one worker #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously if you called
add_jobs()
and passed in 100 jobs, thejobs:insert
announcement would only be made once, resulting in only one idle worker being triggered. i.e. the first of these 100 jobs would start straight away, but the rest would only start once the other workers' poll interval ticked.Now we add the count of the number of jobs queued to the announcement, and we keep nudging workers to look at the job until either there are no more available workers or we've nudged at least this many workers.
Performance impact
There was a performance cost on the queuing side (according to my benchmarks, queuing time could increase by up to 5%) so I've overhauled how queueing works to remove a trigger call and thus the net change is close to zero.
Security impact
None known.
Checklist
yarn lint:fix
passes.I've added tests for the new feature, andyarn test
passes.I have detailed the new feature in the relevant documentation.RELEASE_NOTES.md
file (if one exists).