2 patches, cuda option to remove asyncrhonous ops, cleanup of network_gui.listener #416
+54
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fails, network_gui.listener can block resources, clean up on break.
Random background flag added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/ CUDA
In my system running cudatoolkit 11.8 over NVIDIA-SMI 525.116.04 Driver Version: 525.116.04 CUDA Version: 12.0
I found some errors during training fixable by blocking CUDA asynchronous operations - a bit slower but more robust.
2/ network_gui on interrupted processes listener blocks resources, added linstener.close() and conn.close() on the try except training loop.
Both these could be fixed better.
The first would entail debugging why CUDA is barfing on async ops, I dunno.
The second is easier, network_gui could be a class with enter exit that always frees resources.