Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup interaction with GraphQL service #2

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Cleanup interaction with GraphQL service #2

merged 1 commit into from
Nov 29, 2018

Conversation

matiasanaya
Copy link
Contributor

@matiasanaya matiasanaya commented Nov 13, 2018 •
edited
Loading

BREAKING CHANGE

The benefits of this PR are:

  • Less code required to start a graphQL over websockets server. (as seen in README.md and this other PR)
  • Updating the library to fix mismatches with the spec.

@matiasanaya matiasanaya mentioned this pull request Nov 13, 2018
Merged
@matiasanaya matiasanaya force-pushed the feature/cleaner-interaction branch from 231a415 to 4d200cc Compare November 29, 2018 02:11
@pavelnikolov pavelnikolov merged commit 40b8cf7 into graph-gophers:master Nov 29, 2018
@matiasanaya matiasanaya deleted the feature/cleaner-interaction branch November 29, 2018 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelnikolov pavelnikolov pavelnikolov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasanaya @pavelnikolov