Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] pos_order_to_sale_order #4

Conversation

geomer198
Copy link

@geomer198 geomer198 commented Nov 18, 2023

Code refactoring and fix comments in this PR.

@github-grap-bot
Copy link

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

@legalsylvain
Copy link
Member

Hi @geomer198.
Test are green here : OCA#1080
but red in the current PR. could you take a look ? thanks !

@geomer198
Copy link
Author

Hi @geomer198. Test are green here : OCA#1080 but red in the current PR. could you take a look ? thanks !

I don't have idea about reason errors in the tests. Errors throw in stock_available module. This module doesn't depend on current fixes.

@geomer198
Copy link
Author

@legalsylvain Could you check?

@legalsylvain
Copy link
Member

Hi @geomer198.
sorry, I'm totally busy for the next weeks. Maybe it's better to merge OCA#1080 (because the CI is green), and then you make your PR directly against the OCA repo ? It maybe will solve the CI trouble.

Let me know !

@geomer198
Copy link
Author

Hi @geomer198. sorry, I'm totally busy for the next weeks. Maybe it's better to merge OCA#1080 (because the CI is green), and then you make your PR directly against the OCA repo ? It maybe will solve the CI trouble.

Let me know !

Agree with you! Let's do this.

@geomer198 geomer198 closed this Nov 25, 2023
@geomer198 geomer198 deleted the 16.0-fix-pos_order_to_sale_order-refactoring branch November 25, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants