Handling of grid = TRUE #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id = TRUE (and not just for date/time), except when axis is in logs
grantmcdermott
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Nice! Good catch on the log axes and I think this helps keep cleaner internals, in addition to the generic dispatch. All checks passing, so I'm happy to merge. Users should still be able to pass grid = grid() if they want to enforce the "old" behaviour anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
grid = TRUEis specified, then the newabline(... = pretty(extendrange(...)), ...)is used now instead ofgrid()- and not just for date/time classes (see #77).Reason: Unlike
grid(), the functionpretty()is generic. Thus, it can adapt better to axes for variables of other classes.Only exception: For axes in logs, we still resort to using
grid()which is likely handled better there.Potential downside: In all cases I tried, the
pretty(extendrange(...))approach yielded the same grid positions asgrid(). But there may be situations when differences occur. However, in the examples I tried, I wasn't able to produce such a situation.