Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix y-title for function names #52

Merged
merged 7 commits into from
Aug 6, 2023

Conversation

etiennebacher
Copy link
Contributor

Same as #51, close #47

Much better like this @grantmcdermott

@etiennebacher
Copy link
Contributor Author

What? No idea why it fails now

@grantmcdermott
Copy link
Owner

Super, thanks. I'll take a look on my local Linux machine as soon as the kids get to school.

@grantmcdermott
Copy link
Owner

Hmmm. It looks like the Hershey font tests (and one par restore test) are triggering the CI errors. It's almost certainly nothing to do with this PR, but I'd like to test a bit more locally. I have to jump on some other work first, but will circle back to this later.

@etiennebacher
Copy link
Contributor Author

etiennebacher commented Aug 2, 2023

This fails only on R-devel, could it be due to a recent commit there? For example wch/r-source@fa69bab?

@grantmcdermott
Copy link
Owner

This fails only on R-devel, could it be due to a recent commit there?

Thanks, I think that must be it. I downloaded the action artifact here and manually inspected the _tinysnapshot_review diffs. I honestly can't see what the difference is.... maybe some incredibly slight shading/alpha change? I'll wait for R 4.4.0 to re-generate these snapshots locally

At any rate, happy to accept the PR now. Thanks for the contribution @etiennebacher !

@grantmcdermott grantmcdermott merged commit 2a46cb6 into grantmcdermott:main Aug 6, 2023
5 checks passed
@etiennebacher etiennebacher deleted the fix-ylab branch August 7, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

y-title for function names
2 participants