Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update color reference from arXiv to The R Journal #114

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

zeileis
Copy link
Collaborator

@zeileis zeileis commented Jan 30, 2024

Grant @grantmcdermott , just a mini-update in response to https://fosstodon.org/@devSJR/111838661757048332. Do you prefer if I send you such modifications as PRs or should I merge myself (or commit directly in main)?

@vincentarelbundock
Copy link
Collaborator

Grant can say what workflow he prefers, but this is trivial so I feel I can just review and merge now.

@vincentarelbundock vincentarelbundock merged commit 27c8dcb into main Jan 30, 2024
3 checks passed
@grantmcdermott
Copy link
Owner

Thanks, folks.

To Vincent's point. You should both definitely feel empowered to merge PRs, including your own, that you believe are simple and ready (i.e., pass all tests). For the bigger changes, I'd prefer us to have at least one other person review and I'd obviously like to be tagged in all the design-based changes.

(We can revisit a more formal process once the package hits CRAN. But I feel comfortable that we can just rely on individual judgment 'til then.)

@zeileis
Copy link
Collaborator Author

zeileis commented Jan 30, 2024

Thanks for the explanation, Grant! That's perfect and works very well for me.
I definitely agree that bigger changes should be discussed first and wouldn't merge anything without tagging you first. It was really just about small typos and updates and stuff like that.

@zeileis zeileis deleted the colorref branch January 30, 2024 17:06
@grantmcdermott
Copy link
Owner

Super.

Seeing as we're talking PRs... Just a HU that I'd like to resolve the package name issue (#22 ) as the priority for the next release, since that would obviously be a breaking change if we do proceed. I'll try to summarise my thoughts in the relevant thread when I get a sec and then we can look to make a final call by the end of this week or the next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants