Skip to content

Commit

Permalink
Remove dangling TODO that links to a resolved issue
Browse files Browse the repository at this point in the history
The upstream issue: trinodb#9021 cannot be reproduced, see the issue for details
  • Loading branch information
grantatspothero committed Jan 27, 2022
1 parent 8e9da98 commit 1d55887
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,7 @@ public Optional<AggregationApplicationResult<ConnectorTableHandle>> applyAggrega

List<JdbcColumnHandle> newColumnsList = newColumns.build();

// TODO(https://github.com/trinodb/trino/issues/9021) We are reading all grouping columns from remote database as at this point we are not able to tell if they are needed up in the query.
// As a reason of that we need to also have matching column handles in JdbcTableHandle constructed below, as columns read via JDBC must match column handles list.
// We need to have matching column handles in JdbcTableHandle constructed below, as columns read via JDBC must match column handles list.
// For more context see assertion in JdbcRecordSetProvider.getRecordSet
PreparedQuery preparedQuery = jdbcClient.prepareQuery(
session,
Expand Down

0 comments on commit 1d55887

Please sign in to comment.