Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move slashing protection DB to validator dir #22

Closed
yorickdowne opened this issue Mar 31, 2024 · 2 comments
Closed

Move slashing protection DB to validator dir #22

yorickdowne opened this issue Mar 31, 2024 · 2 comments

Comments

@yorickdowne
Copy link

Currently slashing_protection.sqlite is in beacon. This is un-intuitive and can lead to slashing when a user resyncs the beacon by stopping it, removing the contents of beacon and starting again, depending on how fast the resync from checkpoint is.

Placing it into validator is in line with what other clients do, and makes sense logically, since it's the validator that's being protected from slashing.
@sauliusgrigaitis
Copy link
Member

We should also copy slashing_protection.sqlite from beacon to validator if we don't find slashing_protection.sqlite in validator dir.

SifraiTeam pushed a commit that referenced this issue Apr 12, 2024
@Tumas
Move interchange backup files & slashing_protecion DB to validator_dir …
171f955 
…#22
@yorickdowne
Copy link
Author

Thanks for getting that done!

sauliusgrigaitis pushed a commit that referenced this issue Apr 19, 2024
@Tumas
Create validator if it is missing. #22
5767f98
sauliusgrigaitis pushed a commit that referenced this issue Apr 24, 2024
@Tumas
Create validator dir if missing when moving slashing protection inter…
81065f1 
…change files. #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sauliusgrigaitis @yorickdowne