-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Gramplet: Historical Context (Gramps 5.2) Gramplet will show historical events in the gramplet panel. #615
base: maintenance/gramps52
Are you sure you want to change the base?
Conversation
Great addon thank you :) As for the generic subject line of the pull request
can I suggest you change it to:
or similar and add a proper description here? |
I like this addon; as I was an old time TMG user and created a few personalized TMG Timelines but they used ( a .DBF file and a .DBT file and a DOC file!) and 8 data fields. But I expect I'll just convert to your format even if it looses information... Maybe the instructions to create the csv file can be adapted to your addon ? ( Auto-Creation of (TMG)Timeline Files http://www.tmgtips.com/timelin6.htm ) |
HistContext/HistContext.gpr.py
Outdated
gramplet = "HistContext", | ||
gramplet_title=_("Historical Context"), | ||
gramps_target_version="5.2", | ||
help_url="https://github.com/kajmikkelsen/TimeLineGramplet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to point to the new help page on the Gramps wiki for this addon say
help_url="https://gramps-project.org/wiki/index.php/Addon:Historical_Context",
HistContext/HistContext.gpr.py
Outdated
id="HistContext", | ||
name=_("Historical Context"), | ||
description = _("Displaying a historical context"), | ||
status = BETA, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change status to "STABLE"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Added colous for foreground and background to the options menu Various minor changes to comply with pylint Changed status to stable Updated teemplate.pot to reflect changes in the python code Changed MANIFEST so the pictures in README.md will be distributed
HistContext/README.md
Outdated
A double-click on a row will open your browser at the provided Link | ||
|
||
The gramplet works on the person and the relations view. | ||
The gramplet works on the person and the relations view and will us the bith and death of the active person. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relations = "Relationships Category view"
bith = birth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed person to People, us to use and relations to Relationship Category
changed birt to birth
Committed and pushed
Thanks
Hent BlueMail til Android
Den 4. nov. 2024 13.25, fra 13.25, Call-Me-Dave ***@***.***> skrev:
…
@Call-Me-Dave commented on this pull request.
> A double-click on a row will open your browser at the provided Link
-The gramplet works on the person and the relations view.
+The gramplet works on the person and the relations view and will us
the bith and death of the active person.
relations = "Relationships Category view"
bith = birth
--
Reply to this email directly or view it on GitHub:
#615 (review)
You are receiving this because you authored the thread.
Message ID:
***@***.***>
|
All looks good to me. Any other reason not to publish? |
New Gramplet: Historical Context (Gramps 5.2)
Gramplet will show historical events in the gramplet panel.