Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Gramplet: Historical Context (Gramps 5.2) Gramplet will show historical events in the gramplet panel. #615

Open
wants to merge 7 commits into
base: maintenance/gramps52
Choose a base branch
from

Conversation

kajmikkelsen
Copy link
Contributor

@kajmikkelsen kajmikkelsen commented Nov 2, 2024

New Gramplet: Historical Context (Gramps 5.2)
Gramplet will show historical events in the gramplet panel.

@Call-Me-Dave
Copy link

Great addon thank you :)

As for the generic subject line of the pull request

Initial commit for production the gramplet

can I suggest you change it to:

New Gramplet: Historical Context (Gramps 5.2)

or similar and add a proper description here?

@Call-Me-Dave
Copy link

Call-Me-Dave commented Nov 2, 2024

I like this addon; as I was an old time TMG user and created a few personalized TMG Timelines but they used ( a .DBF file and a .DBT file and a DOC file!) and 8 data fields. But I expect I'll just convert to your format even if it looses information...

Maybe the instructions to create the csv file can be adapted to your addon ? ( Auto-Creation of (TMG)Timeline Files http://www.tmgtips.com/timelin6.htm )

gramplet = "HistContext",
gramplet_title=_("Historical Context"),
gramps_target_version="5.2",
help_url="https://github.com/kajmikkelsen/TimeLineGramplet",
Copy link

@Call-Me-Dave Call-Me-Dave Nov 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to point to the new help page on the Gramps wiki for this addon say

help_url="https://gramps-project.org/wiki/index.php/Addon:Historical_Context",

id="HistContext",
name=_("Historical Context"),
description = _("Displaying a historical context"),
status = BETA,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change status to "STABLE"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Added colous for foreground and background to the options menu
Various minor changes to comply with pylint
Changed status to stable
Updated teemplate.pot to reflect changes in the python code
Changed MANIFEST so the pictures in README.md will be distributed
A double-click on a row will open your browser at the provided Link

The gramplet works on the person and the relations view.
The gramplet works on the person and the relations view and will us the bith and death of the active person.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relations = "Relationships Category view"
bith = birth

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed person to People, us to use and relations to Relationship Category
changed birt to birth
Committed and pushed

@kajmikkelsen
Copy link
Contributor Author

kajmikkelsen commented Nov 4, 2024 via email

@kajmikkelsen kajmikkelsen changed the title Initial commit for production the gramplet New Gramplet: Historical Context (Gramps 5.2) Gramplet will show historical events in the gramplet panel. Nov 6, 2024
@GaryGriffin
Copy link
Member

All looks good to me. Any other reason not to publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants