Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and update dependencies #583

Merged
merged 10 commits into from
Jan 14, 2023
Merged

Refactor and update dependencies #583

merged 10 commits into from
Jan 14, 2023

Conversation

quadratz
Copy link
Contributor

@quadratz quadratz commented Jan 9, 2023

Ciki Momogi added 7 commits January 9, 2023 20:12
Updated package.json to include the correct version range for dependencies. See vuepress/core#1195
Script for previewing the build result (`docs:build`)
Script for upgrading `deno-bin`
VuePress has implemented these rules by default. See vuepress/core#1131
@quadratz quadratz added not translatable Translator intervention is not required. chore Modifies or is related to tooling, configuration, or setup. labels Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

@github-actions github-actions bot temporarily deployed to pull request January 9, 2023 14:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 9, 2023 14:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 9, 2023 14:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 9, 2023 14:32 Inactive
@KnorpelSenf KnorpelSenf requested a review from rojvv January 9, 2023 18:08
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the CSS changes you performed?

site/package.json Outdated Show resolved Hide resolved
@KnorpelSenf KnorpelSenf requested review from KnorpelSenf and Loskir and removed request for KnorpelSenf January 9, 2023 18:10
@quadratz
Copy link
Contributor Author

Can you explain the CSS changes you performed?

It's removing the custom CSS rules for the custom container that we added a while back (#472). We added these rules because vuepress didn't have them at the time, but they've since implemented them. I previously submitted a pull request to vuepress with the same rules that we were using in grammY. So, our custom rules are no longer necessary.

@KnorpelSenf
Copy link
Member

KnorpelSenf commented Jan 10, 2023

Pretty cool!

For future reference, it's vuepress/core#1131 that added these rules. This is pulled in via this PQ.

EDIT: Now I understood what you meant by the PQ description … sorry

@quadratz quadratz requested a review from KnorpelSenf January 10, 2023 10:28
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Updating deno script to display current version by using 'deno --version' command instead of the previous 'deno:upgrade' script, as it was throwing error. As an alternative, one can use 'npm update' to upgrade the deno version.
@github-actions github-actions bot temporarily deployed to pull request January 14, 2023 12:36 Inactive
@quadratz
Copy link
Contributor Author

quadratz commented Jan 14, 2023

eba86b6 - Upon discovering that deno upgrade was not functioning, it was replaced with deno --version for displaying the current version. To upgrade Deno, one can use the command npm update.

@rojvv
Copy link
Member

rojvv commented Jan 14, 2023

Hmm

@rojvv
Copy link
Member

rojvv commented Jan 14, 2023

I badly missed this PR

@quadratz
Copy link
Contributor Author

This PQ is not urgent, so there is no need to rush or hurry. :)

@github-actions github-actions bot temporarily deployed to pull request January 14, 2023 14:00 Inactive
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!

@rojvv rojvv merged commit 37b27cb into main Jan 14, 2023
@rojvv rojvv deleted the refactor branch January 14, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Modifies or is related to tooling, configuration, or setup. not translatable Translator intervention is not required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants