-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and update dependencies #583
Conversation
Updated package.json to include the correct version range for dependencies. See vuepress/core#1195
Script for previewing the build result (`docs:build`)
Script for upgrading `deno-bin`
VuePress has implemented these rules by default. See vuepress/core#1131
🚀 Deployed on https://63c2b55b315d220b7c3119ec--grammy.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the CSS changes you performed?
It's removing the custom CSS rules for the custom container that we added a while back (#472). We added these rules because vuepress didn't have them at the time, but they've since implemented them. I previously submitted a pull request to vuepress with the same rules that we were using in grammY. So, our custom rules are no longer necessary. |
Pretty cool! For future reference, it's vuepress/core#1131 that added these rules. This is pulled in via this PQ. EDIT: Now I understood what you meant by the PQ description … sorry |
Co-authored-by: KnorpelSenf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
Updating deno script to display current version by using 'deno --version' command instead of the previous 'deno:upgrade' script, as it was throwing error. As an alternative, one can use 'npm update' to upgrade the deno version.
eba86b6 - Upon discovering that |
Hmm |
I badly missed this PR |
This PQ is not urgent, so there is no need to rush or hurry. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you so much!
⚠️ATTENTION: Using version range like
^
or~
for packages in this repo will fail. vuepress/core#1195.github-pull-request
to the recommended list.docs:preview
anddocs:deno
scripts.feat(theme-default): redesign custom container vuepress/core#1131
package-lock.json