Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix links #614

Merged
merged 3 commits into from
Jul 18, 2024
Merged

docs: fix links #614

merged 3 commits into from
Jul 18, 2024

Conversation

dcdunkan
Copy link
Member

No description provided.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes but please revert the unrelated whitespace changes to the source code

@dcdunkan
Copy link
Member Author

* @param thumbnail A .WEBP or .PNG image with the thumbnail, must be up to 128 kilobytes in size and have a width and height of exactly 100px, or a .TGS animation with a thumbnail up to 32 kilobytes in size (see https://core.telegram.org/stickers#animated-sticker-requirements for animated sticker technical requirements), or a WEBM video with the thumbnail up to 32 kilobytes in size; see https://core.telegram.org/stickers#video-sticker-requirements for video sticker technical requirements. Pass a file_id as a String to send a file that already exists on the Telegram servers, pass an HTTP URL as a String for Telegram to get a file from the Internet, or upload a new one using multipart/form-data. More information on Sending Files ». Animated and video sticker set thumbnails can't be uploaded via HTTP URL. If omitted, then the thumbnail is dropped and the first sticker is used as the thumbnail.

Here the anchors are outdated and can be updated to video-requirements and animation-requirements. Should I include those as well? Since those docs are from the Bot API docs itself, I didn't know what to do.

@dcdunkan
Copy link
Member Author

Great changes but please revert the unrelated whitespace changes to the source code

My bad. Fixing them...

@KnorpelSenf
Copy link
Member

* @param thumbnail A .WEBP or .PNG image with the thumbnail, must be up to 128 kilobytes in size and have a width and height of exactly 100px, or a .TGS animation with a thumbnail up to 32 kilobytes in size (see https://core.telegram.org/stickers#animated-sticker-requirements for animated sticker technical requirements), or a WEBM video with the thumbnail up to 32 kilobytes in size; see https://core.telegram.org/stickers#video-sticker-requirements for video sticker technical requirements. Pass a file_id as a String to send a file that already exists on the Telegram servers, pass an HTTP URL as a String for Telegram to get a file from the Internet, or upload a new one using multipart/form-data. More information on Sending Files ». Animated and video sticker set thumbnails can't be uploaded via HTTP URL. If omitted, then the thumbnail is dropped and the first sticker is used as the thumbnail.

Here the anchors are outdated and can be updated to video-requirements and animation-requirements. Should I include those as well? Since those docs are from the Bot API docs itself, I didn't know what to do.

Are they also outdated in the official Telegram docs?

@dcdunkan
Copy link
Member Author

Yes

@dcdunkan
Copy link
Member Author

dcdunkan commented Jul 18, 2024

Wait, let me re-check Yes

@KnorpelSenf
Copy link
Member

Then we are going to keep broken links in our documentation, as well, until Telegram fixes the issue. This is going to happen soon.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@KnorpelSenf KnorpelSenf merged commit 31d0ba9 into main Jul 18, 2024
6 checks passed
@KnorpelSenf KnorpelSenf deleted the fix-links branch July 18, 2024 23:24
@KnorpelSenf
Copy link
Member

@dcdunkan are you planning on opening similar PQs to the other repositories in the organisation?

@dcdunkan
Copy link
Member Author

Yes, in my free time.

@KnorpelSenf
Copy link
Member

We can fix it now, it was already done in grammyjs/types@2987b30 for the types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants