fix: avoid top-level await #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 46.08% 46.08%
=======================================
Files 19 19
Lines 6052 6052
Branches 320 320
=======================================
Hits 2789 2789
Misses 3260 3260
Partials 3 3 ☔ View full report in Codecov by Sentry. |
wojpawlik
reviewed
Mar 23, 2024
Comment on lines
+11
to
13
| const res = Deno.permissions.querySync(env); | ||
| let namespace: string | undefined = undefined; | ||
| if (res.state === "granted") namespace = Deno.env.get(DEBUG); |
There was a problem hiding this comment.
Suggested change
| const res = Deno.permissions.querySync(env); | |
| let namespace: string | undefined = undefined; | |
| if (res.state === "granted") namespace = Deno.env.get(DEBUG); | |
| const res = Deno.permissions.querySync?.(env); | |
| let namespace: string | undefined = undefined; | |
| if (!res || res.state === "granted") namespace = Deno.env.get(DEBUG); |
to accomodate Deno Deploy
|
This is more complicated than I thought, and the benefits are small. I will abandon this. |
|
What happened? |
|
TLA is not supported on all platforms, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping the only instance of TLA