Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): do not rely on ReadableStream.from or new ReadableStream #493

Closed
wants to merge 5 commits into from

Conversation

KnightNiwrem
Copy link
Contributor

For #492

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a92b766) 46.51% compared to head (5bd05dd) 46.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   46.51%   46.51%           
=======================================
  Files          19       19           
  Lines        5615     5615           
  Branches      226      226           
=======================================
  Hits         2612     2612           
  Misses       3000     3000           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnightNiwrem
Copy link
Contributor Author

Please feel free to move writer.close() out of the async function, and perhaps into a .finally(...) block instead

@KnightNiwrem
Copy link
Contributor Author

CFW should raise the compatibility date in their config, or set the feature flag: https://developers.cloudflare.com/workers/configuration/compatibility-dates/#streams-constructors

@KnorpelSenf KnorpelSenf deleted the no-readable-from-or-new branch October 8, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants