Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 0.8 release #26

Merged
merged 33 commits into from
Jun 19, 2024
Merged

chore: 0.8 release #26

merged 33 commits into from
Jun 19, 2024

Conversation

carafelix
Copy link
Member

closes #16
closes #18

Major changes:

  • add LanguageCode type to .localize and all interfaces that mentioned language
  • narrow getNearestCommand output based on the user language, add ignoreLocalization flag to revert this
  • expand search of getNearestCommand to multiple Commands instances
  • add .toElementals method, which serialize all register commands, and their localizations.
  • refactor mergeMyCommandsParams function into MyCommandParams static class

minor:

  • lower default similarity threshold for FuzzyMatch
  • add array support for setMyCommands
  • jsdoc improvements

@carafelix carafelix requested a review from roziscoding June 18, 2024 23:01
@carafelix carafelix marked this pull request as draft June 18, 2024 23:02
@carafelix carafelix marked this pull request as ready for review June 18, 2024 23:05
@carafelix carafelix force-pushed the next branch 3 times, most recently from a561d47 to 9a8e7c4 Compare June 18, 2024 23:13
carafelix and others added 24 commits June 18, 2024 20:37
@carafelix
add to setMyCommands param support for passing an array. Move ensure …
3b72180 
…array to utils.ts
@carafelix
add jsdoc examples, deno fmt
0f1fa7e
@carafelix
explicit type import
afeef9e
@carafelix
refactor mergeMyCommandsParams function into a static class
8c7b3e6
@carafelix
update tests to use the static class version, hide internals methods,…
e76d5b3 
… encapsulate related logic, remove the use of ! assertion
@carafelix
improve jsdoc, deno fmt
e5675dc
@carafelix
Apply request changes from review:
ee08b4e 
- add examples to jsdoc
- correct the jsdoc in setMyCommansParams interface
@carafelix
underscore public functions that aren't too relevant but are useful e…
0d61759 
…nough to be public
@carafelix
CHANGE fuzzyMatch return interface, FIX fuzzyMatch from returning a c…
11bcec5 
…ommand that doesn't correspond to the user lang when using localizations
@carafelix
encapsulate fuzzyMatch output so it does not brake prior releases
3a2f9e5
@carafelix
add tests illustrating the collision problem mentioned in bug: #18
8a87a9b
@carafelix
add tests for between-class collisions mentioned in #18
bec70e3
@carafelix
lower similarity threshold to allow 3 letter words with 1 letter diff…
73558bc 
…erence in the last position to match
@carafelix
add test's for proof of concept
660a78d
@carafelix
add ignoreLocalization behavior and tests for it. (ugly code)
f73d083
@carafelix
hide parameter from where it was not use
21001a4
@carafelix
add more test's
f9ec95c
@carafelix
add getNearestCommand support for multiple command instances, improve…
2b0121f 
… namings, add respective test's
@carafelix @roziscoding
Apply suggestions from code review
59e61f1 
Co-authored-by: Roz <[email protected]>
@carafelix
improve coverage by testing on null input
b64a058
@carafelix
export dummy ctx function
fc0f06b
@carafelix
types
19caa43
@carafelix
refactor toElementals
b33ea6e
@carafelix
- add check for ctx.from.id being ISO639 compatible
38cff93 
- improve type inference
- change type dependencies to the @grammyjs/types package
@carafelix carafelix merged commit 6faaea8 into main Jun 19, 2024
12 checks passed
@carafelix carafelix deleted the next branch June 19, 2024 00:54
@carafelix carafelix restored the next branch June 19, 2024 00:55
@carafelix carafelix deleted the next branch June 19, 2024 00:55
@carafelix carafelix restored the next branch June 19, 2024 00:55
@carafelix carafelix deleted the next branch June 19, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roziscoding roziscoding roziscoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@carafelix @roziscoding