fix: localization command names being empty

[carafelix]

fixes #13 by removing regExp conversion to, and type support from _lenguages set in Command class:
output quoted in the issue now looks like:

[
  {
    scope: { type: "chat", chat_id: 333649403 },
    language_code: undefined,
    commands: [
      { command: "start", description: "init bot" },
      { command: "end", description: "end" }
    ]
  },
  {
    scope: { type: "chat", chat_id: 333649403 },
    language_code: "es",
    commands: [
      { command: "iniciar", description: "Inicializa el bot" },
      { command: "fin", description: "finaliza" }
    ]
  }
]

other functionality is not broken

[codecov]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.63%. Comparing base (63bc0fa) to head (761470e).

❗ Current head 761470e differs from pull request most recent head 1ff6856

Please upload reports for the commit 1ff6856 to get more accurate results.

Files	Patch %	Lines
src/command.ts	0.00%	4 Missing ⚠️
src/commands.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   68.13%   67.63%   -0.50%     
==========================================
  Files           7        7              
  Lines         408      411       +3     
  Branches       66       66              
==========================================
  Hits          278      278              
- Misses        128      131       +3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[carafelix]

I have a new idea, instead of making a new regexCommand class, the commands.comand method could accept a type parameter, and check at runtime. I think it should be more straight forward

[roziscoding]

I have a new idea, instead of making a new regexCommand class, the commands.comand method could accept a type parameter, and check at runtime. I think it should be more straight forward

sorry for the delay on this.
what I was thinking is that we could stop converting every command to RegEx, and then we could just skip commands where name is a RegEx when calling setMyCommands (on the toArgs method).
Because RegEx commands aren't meant to be typed by hand or selected from the commands list anyway.

[carafelix]

I have a design question:

• Are RegEx commands meant to be supported by the getNearestCommand method? Because using RegEx.source it could be possible to support the nearest command (since FuzzyMatch its using .toArgs to serialize).
• I think it could be good to also output the prefix from FuzzySearch, so Did you mean ${prefix}${commandName}? can be done.

I'll update the PR to

skip commands where name is a RegEx when calling setMyCommands (on the toArgs method)

And the first point of the two points, if you are good with the 2nd one I can add it too

[carafelix]

Done. Tested in a dummy bot. One thing to note. I didn't add the prefilter of regex to the toArgs, only to the toSingleScopeArgs, since doing that would prevent fuzzyMatch to lookup the regex commands for similar ones. One solution would be to overload the toArgs method for the use case of SetMyCommands and SetCommands``, and another one for fuzzyMatch``` (that one could also output prefix).

[carafelix]

Removed pollution from commit history

[roziscoding]

Would you be willing to add automated tests for the two functions that were changed?
I'd go with something simple like instantiating a command, then calling them and checking if the returned object / array is what we expect. Then do that for a command with string name and with regex name.

WDYT?

[carafelix]

Would you be willing to add automated tests for the two functions that were changed?

Sure, I'll do it asap

[roziscoding]

LGTM
thank you so much! ❤️